Skip to content

Add preset for leisure=summer_camp#2000

Merged
matkoniecz merged 1 commit intoopenstreetmap:mainfrom
ashree2118:add-leisure-summer-camp-1481
Apr 15, 2026
Merged

Add preset for leisure=summer_camp#2000
matkoniecz merged 1 commit intoopenstreetmap:mainfrom
ashree2118:add-leisure-summer-camp-1481

Conversation

@ashree2118
Copy link
Copy Markdown
Contributor

@ashree2118 ashree2118 commented Mar 7, 2026

Description, Motivation & Context

Added a preset for leisure=summer_camp to resolve #1481.

Related issues

Closes #1481

Created because the previous pr #1495 attempting to solve this seemed to fail builds and abandoned.

Links and data

Relevant OSM Wiki links:

  • …

Relevant tag usage stats:

…

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@ashree2118
Copy link
Copy Markdown
Contributor Author

ashree2118 commented Mar 7, 2026

Test-Documentation

Preview links & Sidebar Screenshots

Test confirming the new leisure=summer_camp preset is available.

1. Summer Camp preset:
Screenshot 2026-03-07 221706

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@matkoniecz matkoniecz mentioned this pull request Mar 7, 2026
Closed
matkoniecz
matkoniecz approved these changes Mar 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disclaimer: I am not really familiar with this POI, but based on #1495 (review) and OSM Wiki and cursory check of info on Internet it seems a real and reasonable POI type

I expect it will stay open for a while for review from wider OSM community

opened https://community.openstreetmap.org/t/if-leisure-summer-camp-is-a-terrible-tagging-schema-it-would-be-a-good-moment-to-protest/142098

(but even if tagging scheme is bad, that does not change that PR itself is fine and was based on open issue)

@andrewharvey
Copy link
Copy Markdown
Collaborator

andrewharvey commented Mar 9, 2026 •
edited
Loading

I approve this change.

But I suggest we add seasonal as a field (for example as we do for leisure=ice_rink.

It shouldn't hold up this PR, but it looks like the seasonal field is only a yes/no toggle, ideally it would support all the other values spring/summer/autumn/winter/wet_season/dry_season from https://wiki.openstreetmap.org/wiki/Key:seasonal

Other fields could include:

  • operator
  • website
  • phone

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Mar 11, 2026

discussion is active at https://community.openstreetmap.org/t/if-leisure-summer-camp-is-a-terrible-tagging-schema-it-would-be-a-good-moment-to-protest/142098/31 so for now I would wait with merge

I posted there that I would recommend waiting with merge here, as long as discussion is active or if there would be attempt to introduce a less confusing tagging schema.

@matkoniecz matkoniecz added the considering May be rejected or approved, decision was not taken yet. Rejection is more likely than typical. label Mar 13, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Mar 27, 2026 •
edited
Loading

https://community.openstreetmap.org/t/if-leisure-summer-camp-is-a-terrible-tagging-schema-it-would-be-a-good-moment-to-protest/142098/41

EDIT: looks like it will be merged relatively soon

@matkoniecz matkoniecz removed the considering May be rejected or approved, decision was not taken yet. Rejection is more likely than typical. label Mar 30, 2026
@matkoniecz matkoniecz merged commit 5e1d4b0 into openstreetmap:main Apr 15, 2026
5 checks passed
@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Apr 15, 2026

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!

@matkoniecz matkoniecz changed the title Add preset for leisure=summer_camp (#1481) Add preset for leisure=summer_camp Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matkoniecz matkoniecz matkoniecz approved these changes

Assignees

No one assigned

Labels

new-preset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add leisure=summer_camp preset

3 participants

@ashree2118 @andrewharvey @matkoniecz
⚡